Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests) EIP-7069 RETURNDATALOAD and RETURNDATACOPY #595

Merged
merged 21 commits into from
Jun 10, 2024
Merged

new(tests) EIP-7069 RETURNDATALOAD and RETURNDATACOPY #595

merged 21 commits into from
Jun 10, 2024

Conversation

shemnon
Copy link
Collaborator

@shemnon shemnon commented Jun 6, 2024

🗒️ Description

Test new RETURNDATACOPY semantics across both EOF and Legacy.
Test RETURNDATALOAD semantics. Includes boundary conditions on both.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

shemnon added 16 commits April 24, 2024 07:33
@shemnon
Validate EIP-7676 Prepare for Address Space Extension
b005113 
Validate ASE behaviors on legacy and EOF opcodes for ASE, when targeting
EOAs, Contracts, and empty accounts.  Opcodes are BALANCE, EXTCALL/CALL,
EXTDELEGATECALL/DELEGATECALL,  EXTSTATICCALL/STATICCALL, and CALLCODE.

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
Reviewer requested changes
52be716 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
formatting
f5dd04a 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
speling
b88130d 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
comment out balance from ASE checks
2966ef5 
EIP-7676 moved the critical EXTCALL sections into the main spec.
EOF does not depend on a new BALANCE op, so don't test it.

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
Merge branch 'main' of github.com:ethereum/execution-spec-tests into …
eb0badf 
…eof/ase
@shemnon
move to new subfolder
6c3a028 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
Recast as EIP-7069 test
7882ef0 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
use itertools.count instead of hard coded address
988996b 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
Review changes
4ecae63 
* Apply specific edits
* Parameterize by opcode as well

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
Merge branch 'main' of github.com:ethereum/execution-spec-tests into …
a979246 
…eof/ase
@shemnon
tox fixes
97ed1e1 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
Merge branch 'main' of github.com:ethereum/execution-spec-tests into …
2a7b7d5 
…eof/ase
@shemnon
remove RETURNDATALOAD from ASE tests
4754460 
Remove RETURNDATALOAD from ASE tests, to be moved to a different test

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
reviewer comments
338ff16 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
new(tests) EIP-7069 RETURNDATALOAD and RETURNDATACOPY
3126847 
Test new RETURNDATACOPY semantics across both EOF and Legacy.
Test RETURNDATALOAD semantics. Includes boundary conditions on both.

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
Copy link
Collaborator Author

shemnon commented Jun 6, 2024

Will rebase and force push once #522 is merged.

marioevz
marioevz reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, thanks!

tests/prague/eip7692_eof_v1/eip7069_extcall/spec.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_returndataload.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_returndataload.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_returndataload.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_returndataload.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_returndataload.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_address_space_extension.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_returndataload.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_returndataload.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_returndataload.py Outdated Show resolved Hide resolved
shemnon added 3 commits June 8, 2024 14:53
@shemnon
review changes
6cd67d2 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
merge main
21302d9 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
unneeded changes.
8300834 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon shemnon force-pushed the eof/returndataload branch from 357cd0f to 8300834 Compare June 8, 2024 21:04
@marioevz marioevz mentioned this pull request Jun 10, 2024
Closed
marioevz
marioevz approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, loved the latest changes it's pretty clean, thanks for this.

@marioevz marioevz merged commit de57ee5 into ethereum:main Jun 10, 2024
5 checks passed
@pdobacz pdobacz mentioned this pull request Jun 10, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shemnon @marioevz