-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(fw,tests,github): Add automatic feature-based fixture building in CI, add EOF feature (eip7692), fix outstanding EOF test failures #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
added
scope:tests
Scope: Test cases
scope:ci
Scope: Continuous Integration
type:chore
Type: Chore
type:feat
type: Feature
scope:fw
Scope: Framework (evm|tools|forks|pytest)
labels
May 27, 2024
This was referenced May 27, 2024
spencer-tb
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the framework/CI side of things!
danceratopz
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Framework & CI also look good to me.
marioevz
changed the title
new(fw,tests): EOF: Enable tox verification on CI, fix existing EOF tests
new(fw,tests,github): Add automatic feature-based fixture building in CI, add EOF feature (eip7692), fix outstanding EOF test failures
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope:ci
Scope: Continuous Integration
scope:fw
Scope: Framework (evm|tools|forks|pytest)
scope:tests
Scope: Test cases
type:chore
Type: Chore
type:feat
type: Feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
fixtures_eof.tar.gz
on release.evmone
to fill tests in Prague fork, even when therequests_hash
is not returned by it (Created issue Remove workaround toevmone
not supporting EIP-6110/EIP-7002 introduced in #573 #574 to remove this in the future).no_data_section_contents
anddata_section_contents_incomplete
have been commented out. Issue Fix, clarify, or create alternative tests to incomplete data section tests #575 has been created to track re-enabling these tests.🔗 Related Issues
None
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.