Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(fw,tests,github): Add automatic feature-based fixture building in CI, add EOF feature (eip7692), fix outstanding EOF test failures #573

Merged
merged 26 commits into from
May 30, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented May 27, 2024

🗒️ Description

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:tests Scope: Test cases scope:ci Scope: Continuous Integration type:chore Type: Chore type:feat type: Feature scope:fw Scope: Framework (evm|tools|forks|pytest) labels May 27, 2024
@marioevz marioevz requested a review from winsvega May 27, 2024 22:16
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the framework/CI side of things!

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Framework & CI also look good to me.

@marioevz marioevz changed the title new(fw,tests): EOF: Enable tox verification on CI, fix existing EOF tests new(fw,tests,github): Add automatic feature-based fixture building in CI, add EOF feature (eip7692), fix outstanding EOF test failures May 29, 2024
@marioevz marioevz merged commit c6152f0 into main May 30, 2024
9 checks passed
@marioevz marioevz deleted the tox-eof-evmone branch May 30, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Scope: Continuous Integration scope:fw Scope: Framework (evm|tools|forks|pytest) scope:tests Scope: Test cases type:chore Type: Chore type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants