Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(test): add tests for EOF/EIP-663 DUPN SWAPN #502

Merged
merged 8 commits into from
May 23, 2024
Merged

new(test): add tests for EOF/EIP-663 DUPN SWAPN #502

merged 8 commits into from
May 23, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Apr 12, 2024 •
edited
Loading

🗒️ Description

Adds new tests for EIP-663.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast chfast force-pushed the eof/eip663_dupn_swapn branch from 5a3160f to 0384418 Compare April 12, 2024 11:14
@danceratopz danceratopz added scope:tests Scope: Test cases type:feat type: Feature labels Apr 16, 2024
@chfast chfast force-pushed the eof/eip663_dupn_swapn branch 2 times, most recently from f5f8a3c to 1fe701e Compare April 19, 2024 09:49
@chfast chfast marked this pull request as ready for review April 19, 2024 09:55
marioevz
marioevz reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! A few comments.

tests/prague/eip663_dupn_swapn_exchange/__init__.py Outdated Show resolved Hide resolved
tests/prague/eip663_dupn_swapn_exchange/test_dupn.py Outdated Show resolved Hide resolved
tests/prague/eip663_dupn_swapn_exchange/test_dupn.py Outdated Show resolved Hide resolved
tests/prague/eip663_dupn_swapn_exchange/test_dupn.py Outdated Show resolved Hide resolved
tests/prague/eip663_dupn_swapn_exchange/test_swapn.py Outdated Show resolved Hide resolved
tests/prague/eip663_dupn_swapn_exchange/test_dupn.py Outdated Show resolved Hide resolved
tests/prague/eip663_dupn_swapn_exchange/test_dupn.py Outdated Show resolved Hide resolved
tests/prague/eip663_dupn_swapn_exchange/test_swapn.py Outdated Show resolved Hide resolved
tests/prague/eip663_dupn_swapn_exchange/test_dupn.py Outdated Show resolved Hide resolved
tests/prague/eip663_dupn_swapn_exchange/test_swapn.py Outdated Show resolved Hide resolved
@chfast chfast force-pushed the eof/eip663_dupn_swapn branch 3 times, most recently from 638328e to b924e3d Compare April 26, 2024 15:48
@shemnon shemnon mentioned this pull request May 3, 2024
Merged
7 tasks
@chfast
Copy link
Member Author

chfast commented May 6, 2024

Ping.

@chfast chfast force-pushed the eof/eip663_dupn_swapn branch from b924e3d to d342b73 Compare May 15, 2024 12:11
@chfast chfast force-pushed the eof/eip663_dupn_swapn branch from d342b73 to 7560ee7 Compare May 15, 2024 12:20
@marioevz marioevz merged commit fd7361a into ethereum:main May 23, 2024
5 checks passed
@chfast chfast deleted the eof/eip663_dupn_swapn branch May 23, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
scope:tests Scope: Test cases type:feat type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chfast @marioevz @danceratopz