-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests): EIP-1153: Convert tests from ethereum/tests
#440
Conversation
c41f3bd
to
b59b40f
Compare
0add0ff
to
df6bc6b
Compare
This PR depends on OOG implementation #457 EVMONE calculated coverage diff. on all mentioned converted files vs pyspec generated files hit 20 new lines and 18 new functions/paths |
4e41d53
to
df23f8d
Compare
I pointed it to op_oog so that git diff is clean. |
590ef74
to
be2cb3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how these tests read!
I think we should merge these into the existing 1153 tests in due course as we now have essentially two separate bodies of tests (it's quite confusing in the online doc).
d52674f
to
39ba4c2
Compare
tests removed from repo: also introduced fixes to the coverage script |
37868f1
to
aa0a9f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, some comments mainly because of the recently merged #584.
"some" comments ? ) I just updated it on recent main branch and it has to be all reworked again.. |
cfa542a
to
bf7da58
Compare
@marioevz |
3a6736b
to
4e92159
Compare
add converted-ethereum-tests.txt tests tested with geth evm 1.13.11-unstable
ethereum/tests
the yul coverage had type3 tx.
|
🗒️ Description
convert vectors
1,2,3,4,5,6,7,8,9 11,12, 16,18, ,20
add a little parametrisation around calls
need review
EVMONE calculated coverage diff. on all mentioned converted files vs pyspec generated files
http://retesteth.ethdevops.io/temp/evmone/DIFF/
🔗 Related Issues
#437
Tests remove PR: ethereum/tests#1383
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.