feat(tests): add a test to check that a contract creating blob tx is invalid #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
commented
Oct 12, 2023
| @pytest.mark.parametrize("destination_account", [None], ids=[""]) | ||
| @pytest.mark.parametrize("tx_calldata", [Initcode(deploy_code=Op.SSTORE(0, 1))], ids=[""]) | ||
| @pytest.mark.parametrize("tx_gas", [100_000], ids=[""]) | ||
| @pytest.mark.parametrize("tx_error", ["contract creation not possible in blob tx"], ids=[""]) |
There was a problem hiding this comment.
I just made up this tx_error message (didn't find one). But, it could be that it's not checked/used due to the if in L279:
|
Closing as maintaining our own custom version of geth that bypasses transaction marshalling, cf marioevz/go-ethereum@86b482b is not really a feasible long-term solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds a test that a type 3 transaction that sets the tx
tofield tonilis invalid.t8n tool: marioevz/go-ethereum@86b482b
🔗 Related Issues
N/A
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.