Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): EIP-2537: remove BLS MUL precompiles (MVP) #1039

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Dec 19, 2024

🗒️ Description

This is a set of minimal changes that removes the BLS G1/G2 MUL precompiles (EIP-2537). All existing tests for MULs are redirected to MSMs because these are ABI and gas equivalent (main reason for the spec change).

You can also notice that we had more tests for MULs than for MSMs meaning there were test cases missing for MSMs.

I have filled these tests with modified evmone.

🔗 Related Issues

EIP-2537 update: ethereum/EIPs#8945

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

This is a set of minimal changes that removes the BLS G1/G2 MUL
precompiles (EIP-2537). All existing tests for MULs are redirected
to MSMs because these are ABI and gas equivalent (main reason for
the spec change).

You can also notice that we had more tests for MULs than for MSMs
meaning there were test cases missing for MSMs.

I have filled these tests with modified evmone.
@chfast
Copy link
Member Author

chfast commented Dec 20, 2024

The EELS change: ethereum/execution-specs#1063.

@marioevz marioevz self-requested a review December 20, 2024 15:33
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, very clean. Thanks!

@marioevz marioevz changed the title chore(tests): remove BLS MUL precompiles (MVP) chore(tests): EIP-2537: remove BLS MUL precompiles (MVP) Dec 20, 2024
@marioevz marioevz merged commit 49c766f into ethereum:main Dec 20, 2024
3 checks passed
@marioevz marioevz deleted the 2537_remove_mul branch December 20, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants