Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clis,specs): Tests marked as slow have greater t8n server timeout #1037

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Dec 19, 2024

🗒️ Description

Allow tests marked as slow (with @pytest.mark.slow) to have a higher timeout when making a request to the t8n server.

I was writing a test to verify the maximum discount BLS multi-scalar-multiplication and it takes the t8n server 30 seconds to respond, which exceeds the 20 second timeout that is hard-coded by default.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz requested a review from winsvega December 19, 2024 19:29
@winsvega
Copy link
Collaborator

That's a good flag, but not to confuse with time consuming. Some tests we have just run so many loops or have so many transactions, I marked them as time-consuming to be able to disable from test runs if needed

Copy link
Collaborator

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also timeout is same for all t8ns?

@marioevz
Copy link
Member Author

marioevz commented Dec 20, 2024

not to confuse with time consuming

Indeed, I think it should be fine by now to not be so granular, but if required we could prepare separate markers for:

  1. A single t8n call is the cause for execution delay
  2. Test requires multiple block fills and hence the slowness

Also timeout is same for all t8ns?

This might be EELS only, but need to check with other fillers

@marioevz marioevz merged commit 7bb9588 into main Dec 20, 2024
5 checks passed
@marioevz marioevz deleted the t8n-slow-requests branch December 20, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants