-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tests): EOF - EIP-4200: confirm migration of RJUMP* tests #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
eof/migrate_rjumps
branch
2 times, most recently
from
December 18, 2024 22:25
5f149f9
to
5b11203
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- converted-ethereum-tests.txt: Language not supported
chfast
force-pushed
the
eof/migrate_rjumps
branch
from
December 19, 2024 07:59
5b11203
to
6c18a1f
Compare
pdobacz
approved these changes
Dec 19, 2024
chfast
force-pushed
the
eof/migrate_rjumps
branch
from
December 19, 2024 15:05
6c18a1f
to
1728142
Compare
shemnon
approved these changes
Dec 19, 2024
marioevz
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes!
The EOF validation tests related to rjumps (EIP-4200) are already here. This change confirms the migration is completed and updates the EOF test tracker. There is some additional refactoring done in the tests to trigger the test coverage CI job.
chfast
force-pushed
the
eof/migrate_rjumps
branch
from
December 19, 2024 18:16
1728142
to
081bacb
Compare
marioevz
approved these changes
Dec 20, 2024
marioevz
changed the title
refactor(tests): confirm migration of EOF rjump tests
refactor(tests): EOF - EIP-4200: confirm migration of RJUMP* tests
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
The EOF validation tests related to rjumps (EIP-4200) are already here. This change confirms the migration is completed and updates the EOF test tracker.
There is some additional refactoring done in the tests to trigger the test coverage CI job.
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.