Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests): EOF - EIP-4200: confirm migration of RJUMP* tests #1031

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Dec 18, 2024

🗒️ Description

The EOF validation tests related to rjumps (EIP-4200) are already here. This change confirms the migration is completed and updates the EOF test tracker.

There is some additional refactoring done in the tests to trigger the test coverage CI job.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened: remove migrated EOF RJUMP validation tests tests#1421
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast chfast added scope:tests Scope: Test cases type:test Type: Test labels Dec 18, 2024
@chfast chfast force-pushed the eof/migrate_rjumps branch 2 times, most recently from 5f149f9 to 5b11203 Compare December 18, 2024 22:25
@chfast chfast requested a review from Copilot December 18, 2024 22:26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • converted-ethereum-tests.txt: Language not supported
@chfast chfast marked this pull request as ready for review December 18, 2024 22:29
@chfast chfast force-pushed the eof/migrate_rjumps branch from 5b11203 to 6c18a1f Compare December 19, 2024 07:59
@chfast chfast force-pushed the eof/migrate_rjumps branch from 6c18a1f to 1728142 Compare December 19, 2024 15:05
@chfast chfast requested review from shemnon and marioevz December 19, 2024 15:19
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

The EOF validation tests related to rjumps (EIP-4200) are already here.
This change confirms the migration is completed and updates the EOF
test tracker.

There is some additional refactoring done in the tests to trigger
the test coverage CI job.
@chfast chfast force-pushed the eof/migrate_rjumps branch from 1728142 to 081bacb Compare December 19, 2024 18:16
@marioevz marioevz changed the title refactor(tests): confirm migration of EOF rjump tests refactor(tests): EOF - EIP-4200: confirm migration of RJUMP* tests Dec 27, 2024
@marioevz marioevz merged commit ca91240 into ethereum:main Dec 27, 2024
3 checks passed
@marioevz marioevz deleted the eof/migrate_rjumps branch December 27, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Test cases type:test Type: Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants