-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-2537: Update test files to latest gas schedule #9217
base: master
Are you sure you want to change the base?
Conversation
File
|
@jochem-brouwer could you have any of @marioevz / @lightclient / @MarekM25 (or whoever is best informed on this) give it a review/approve before I merge it? |
If one of the clients could check if the changed test files match their implementation that would be great 😄 👍 |
I checked the differences and found a couple of things:
I updated the JSON files in EEST with the ones in this PR and the generated files were identical. Nevertheless I will open a PR in EEST to update them just for them to be up to date, although we will keep the mul_ JSON files. |
It is actually a good point regarding the |
c56af63
to
b00f566
Compare
b00f566
to
da6ea58
Compare
I have updated this PR, @marioevz could you please re-check? I have now kept in the |
I wanted to keep the original formatting in the json files, but my VSCode keeps messing up the indentation which is why the diff here looks super huge (only the |
This PR updates the test files linked in EIP-2537 to reflect:
These files pass the tests on EthereumJS ethereumjs/ethereumjs-monorepo#3807 and the BLS precompiles also pass the latest Pectra tests: https://github.com/ethereum/execution-spec-tests/releases/tag/pectra-devnet-5%40v1.1.0
If another client could double-check that the modified files are correct, that would be great 😄 👍