This repository has been archived by the owner on Aug 22, 2018. It is now read-only.
[FEATURE] Initial support for MyEtherWallet keystore files import #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josipbagaric
changed the title
|
This looks good so far. Please implement
To complete the PR |
|
@kosecki123 Implemented. |
|
@lsaether Thanks for checking it out. Fixed failing tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for importing keystore files from MyEtherWallet as a wallet for the eac.js client.
Note: In order to work properly with the eth-alarm-clock-dapp, this PR relies on some of the work in @kuzirashi's PR #51. Please merge that one first before merging this one.
@lsaether @kosecki123