Fix input search placeholder style #287
Conversation
| @@ -257,9 +257,14 @@ li.folder > ul > li.file { | |||
| .sidebar .search input[type="search"], | |||
| .sidebar .search input[type="search"]:focus { | |||
| background-color: #2d1763; | |||
| background-image: url("data:image/svg+xml,%3Csvg height='20px' width='20px' viewBox='0 0 24 24' fill='none' stroke='rgba(255, 255, 255, 0.5)' stroke-width='1.5' stroke-linecap='round' stroke-linejoin='round' preserveAspectRatio='xMidYMid meet' xmlns='http://www.w3.org/2000/svg'%3E%3Ccircle cx='10.5' cy='10.5' r='7.5' vector-effect='non-scaling-stroke'%3E%3C/circle%3E%3Cline x1='21' y1='21' x2='15.8' y2='15.8' vector-effect='non-scaling-stroke'%3E%3C/line%3E%3C/svg%3E"); | |||
There was a problem hiding this comment.
Thanks for your contribution. Could you describe what issue are you fixing?
Are you trying to override the SVG from plugin-search?
There was a problem hiding this comment.
thank you for reviewing,
Thanks for your contribution. Could you describe what issue are you fixing?
I was trying to fix the placeholder and icon within the search input, because it is blurred, not contrast with the background (hard to see).
Are you trying to override the SVG from
plugin-search?
ohh, is that cause by the plugin? I don't know about that
There was a problem hiding this comment.
+1 to rahul's question. The current search bar looks good to me, not sure what the issue. Can you please send a screenshot and describe it?
There was a problem hiding this comment.
I think it is caused by the theme. it will show like above if in light theme
There was a problem hiding this comment.
the code block is also having contrast issue with the background when in light theme
There was a problem hiding this comment.
Interesting, this is how ti renders for me:
Can you report what browser/OS are you using? Are you sure it's not caused by extension or some settings?
Across all my browsers and devices, both search bar placeholder and block of code are readable. But I agree it should be more explicit in css to avoid breaking in some browsers
There was a problem hiding this comment.
yeah, it's working fine in dark theme. I use Brave browser on MacOS computer
Wiki PR Checklist
Thank you for contributing to the Protocol Wiki! Before you open a PR, make sure to read information for contributors and take a look at following checklist: