Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 fix: Content text color #252

Merged
merged 3 commits into from
May 7, 2024
Merged

🐞 fix: Content text color #252

merged 3 commits into from
May 7, 2024

Conversation

raxhvl
Copy link
Member

@raxhvl raxhvl commented May 3, 2024

  • Fixes a readability issue with text on some browsers.
  • Typos

This comment was marked as resolved.

@taxmeifyoucan
Copy link
Contributor

@biafra23 Can you please give one a test before we merge?

@biafra23
Copy link
Contributor

biafra23 commented May 6, 2024

How do I test this before you merge?

@raxhvl
Copy link
Member Author

raxhvl commented May 6, 2024

Preview changes on this link: https://epf-wiki-git-fix-theme-text-color-0xrahls-projects.vercel.app/

@taxmeifyoucan
Copy link
Contributor

Here is the difference in my browser. The body of text is not just brighter but also bigger.
What do you think about setting a slightly dimmer or smaller font for the body? Something in between these two.

image
image

@biafra23
Copy link
Contributor

biafra23 commented May 6, 2024

Firefox on MacOS:

The main text is fine. But the headlines are not.
image

@taxmeifyoucan
Copy link
Contributor

Thanks a lot Dirk!

@raxhvl Let's divide it into style for Hs, body, sidebar so we can define slight differences between each.

@raxhvl
Copy link
Member Author

raxhvl commented May 7, 2024

I'm unable to reproduce this on my mac + firefox setup. Here is how the production site renders:
aKtu2PbVIzC5

@raxhvl Let's divide it into style for Hs, body, sidebar so we can define slight differences between each.

Sure.

@raxhvl
Copy link
Member Author

raxhvl commented May 7, 2024

@taxmeifyoucan I have adjusted the color. Headings are white, content is few shades darker. You could fine tune here:

--base-color: #fff;
--heading-color: #fff;
--primary-text-color: #d3d3d3;

Preview link: https://epf-wiki-git-fix-theme-text-color-0xrahls-projects.vercel.app/#/

@taxmeifyoucan
Copy link
Contributor

Great, thanks a lot Rahul! Looks good in my browser.

@biafra23 Can you please check again whether it looks all good now?

@biafra23
Copy link
Contributor

biafra23 commented May 7, 2024

Looks good for me (Firefox & Chrome on macOS):
image

@taxmeifyoucan
Copy link
Contributor

Awesome, thanks a lot guys!

@taxmeifyoucan taxmeifyoucan merged commit b9e25ef into main May 7, 2024
2 checks passed
@taxmeifyoucan taxmeifyoucan deleted the fix/theme-text-color branch May 7, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants