-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞 fix: Content text color #252
Conversation
raxhvl
commented
May 3, 2024
•
edited
Loading
edited
- Fixes a readability issue with text on some browsers.
- Typos
This comment was marked as resolved.
This comment was marked as resolved.
@biafra23 Can you please give one a test before we merge? |
How do I test this before you merge? |
Preview changes on this link: https://epf-wiki-git-fix-theme-text-color-0xrahls-projects.vercel.app/ |
Thanks a lot Dirk! @raxhvl Let's divide it into style for Hs, body, sidebar so we can define slight differences between each. |
I'm unable to reproduce this on my mac + firefox setup. Here is how the production site renders:
Sure. |
@taxmeifyoucan I have adjusted the color. Headings are white, content is few shades darker. You could fine tune here: protocol-studies/docs/assets/css/custom.css Lines 175 to 177 in 91b8d15
Preview link: https://epf-wiki-git-fix-theme-text-color-0xrahls-projects.vercel.app/#/ |
Great, thanks a lot Rahul! Looks good in my browser. @biafra23 Can you please check again whether it looks all good now? |
Awesome, thanks a lot guys! |