-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSZ and Merkleization wiki pages #244
Conversation
Update cl-architecture branch
SSZ and Merkelization wiki pages are done.
resolve conflicts - sidebar and wordlist
I'll review this after our call today. |
Updated for the suggestions after the review by Mario.
@taxmeifyoucan This is ready to be merged. Thx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! So much information. So much detail. It's next level.
I just have a few nitpicks.
I'm not sure if we have a policy on line length. I generally go with 80-120. A formatter can probably fix that if it's something we would like to have. Not the end of the world. Just nice for someone who doesn't have wrapping on their editor.
It looks like the colour scheme for the charts don't really work well with dark mode. I'm not sure what to do about that. Maybe just use outlines? Or specify the text colour as well so it isn't converted into a lighter colour in dark mode.
Fixed the sugestions from Angaz
wordlist conflicts resolved
@taxmeifyoucan @angaz I pushed a commit with all the above suggestions, removed custom colors on the mermaid graphs, standardized the lists formatting, etc. This is ready to be merged. |
Fixed the sidebar links, removed /docs/
Thanks for all the reviews and updates guys! |
Hi @thogiti, Following typos were found in the pull request:
ℹ️ Here's how to fix them:
|
@thogiti I submited the review after the merge. Small nits. It's a great article overall. Thank you. |
Sorry for merging too soon! Please push more updates to |
Love it. Our wiki will be better with more reviews, feedback and comments. Thank you @raxhvl, @angaz, and @taxmeifyoucan for the feedback. I will apply the changes/updates in a new PR and request you to merge it. |
Wiki PR Checklist