Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for setuptools yanked version #8

Merged

Conversation

remyroy
Copy link
Member

@remyroy remyroy commented Apr 16, 2024

Fixes #6

@remyroy
Copy link
Member Author

remyroy commented Apr 16, 2024

This is related to pypa/setuptools#4302

@valefar-on-discord valefar-on-discord self-assigned this Apr 16, 2024
@valefar-on-discord
Copy link
Collaborator

valefar-on-discord commented Apr 16, 2024

Copy link
Collaborator

@valefar-on-discord valefar-on-discord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a net positive but we might want to investigate not using setuptools given the security concern laid out above, unless I misunderstood.

@valefar-on-discord valefar-on-discord merged commit c76efc4 into eth-educators:main Apr 17, 2024
12 checks passed
@remyroy
Copy link
Member Author

remyroy commented Apr 17, 2024

Thoughts on this?: https://pip.pypa.io/en/stable/topics/secure-installs#do-not-use-setuptools-directly

Let me explore this in details.

@remyroy
Copy link
Member Author

remyroy commented Apr 17, 2024

The projects calls deprecated interfaces like python setup.py install which requires setuptools in https://github.com/eth-educators/ethstaker-deposit-cli/blob/main/deposit.sh#L8 for instance. As long as we have those, we need to have setuptools and a recent version for python 3.12 support.

Eventually, we might want to clean that up. I created #11 about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the setuptools package
2 participants