Make sure to wait for the process to exit to prevent some races

eth-educators · May 28, 2024 · 9704f76 · 9704f76
1 parent c35380e
commit 9704f76
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 0 deletions.
diff --git a/test_binary_btec_script.py b/test_binary_btec_script.py
@@ -61,6 +61,8 @@ async def main(argv):
 
     assert len(seed_phrase) > 0
 
+    await proc.wait()
+
     # Check files
     validator_keys_folder_path = os.path.join(my_folder_path, DEFAULT_VALIDATOR_KEYS_FOLDER_NAME)
     _, _, key_files = next(os.walk(validator_keys_folder_path))

diff --git a/test_binary_deposit_script.py b/test_binary_deposit_script.py
@@ -57,6 +57,8 @@ async def main(argv):
 
     assert len(seed_phrase) > 0
 
+    await proc.wait()
+
     # Check files
     validator_keys_folder_path = os.path.join(my_folder_path, DEFAULT_VALIDATOR_KEYS_FOLDER_NAME)
     _, _, key_files = next(os.walk(validator_keys_folder_path))

diff --git a/test_btec_script.py b/test_btec_script.py
@@ -66,6 +66,8 @@ async def main():
 
     assert len(seed_phrase) > 0
 
+    await proc.wait()
+
     # Check files
     validator_keys_folder_path = os.path.join(my_folder_path, DEFAULT_VALIDATOR_KEYS_FOLDER_NAME)
     _, _, key_files = next(os.walk(validator_keys_folder_path))

diff --git a/test_deposit_script.py b/test_deposit_script.py
@@ -62,6 +62,8 @@ async def main():
 
     assert len(seed_phrase) > 0
 
+    await proc.wait()
+
     # Check files
     validator_keys_folder_path = os.path.join(my_folder_path, DEFAULT_VALIDATOR_KEYS_FOLDER_NAME)
     _, _, key_files = next(os.walk(validator_keys_folder_path))

diff --git a/tests/test_cli/test_existing_mnemonic.py b/tests/test_cli/test_existing_mnemonic.py
@@ -281,6 +281,7 @@ async def test_script() -> None:
         ' '.join(cmd_args),
     )
     await proc.wait()
+
     # Check files
     validator_keys_folder_path = os.path.join(my_folder_path, DEFAULT_VALIDATOR_KEYS_FOLDER_NAME)
     _, _, key_files = next(os.walk(validator_keys_folder_path))
@@ -329,6 +330,7 @@ async def test_script_abbreviated_mnemonic() -> None:
         ' '.join(cmd_args),
     )
     await proc.wait()
+
     # Check files
     validator_keys_folder_path = os.path.join(my_folder_path, DEFAULT_VALIDATOR_KEYS_FOLDER_NAME)
     _, _, key_files = next(os.walk(validator_keys_folder_path))

diff --git a/tests/test_cli/test_new_mnemonic.py b/tests/test_cli/test_new_mnemonic.py
@@ -409,6 +409,8 @@ async def test_script_bls_withdrawal() -> None:
 
     assert len(seed_phrase) > 0
 
+    await proc.wait()
+
     # Check files
     validator_keys_folder_path = os.path.join(my_folder_path, DEFAULT_VALIDATOR_KEYS_FOLDER_NAME)
     _, _, key_files = next(os.walk(validator_keys_folder_path))
@@ -495,6 +497,8 @@ async def test_script_abbreviated_mnemonic() -> None:
 
     assert len(seed_phrase) > 0
 
+    await proc.wait()
+
     # Check files
     validator_keys_folder_path = os.path.join(my_folder_path, DEFAULT_VALIDATOR_KEYS_FOLDER_NAME)
     _, _, key_files = next(os.walk(validator_keys_folder_path))