Fix issue with thumbnail in InputMedia types #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have nothing against this PR, but cannot confirm if it is right or not. |
|
Hi, sorry took me a while to write this comment. This change looks reasonable, however, you haven't made changes for the async version. Could you do that as well? |
|
@coder2020official Hi, sorry. I thought the changes made were also intended for the asynchronous version. I have made the corrections, but please be aware that I am currently unable to test with the asynchronous version. |
|
Looks fine. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where
InputFileobjects in thethumbnailfield caused JSON serialization errors.Modified the function
convert_input_media_arrayto extractInputFileobjects fromthumbnailand replace them withattach://references.Describe your tests
Tested with multiple configurations of
InputMediaarrays, including videos and images with local files asthumbnail.Verified successful requests to the Telegram API to upload media groups with proper file attachments.
Confirmed that JSON serialization no longer fails when
InputFileis present.Python version:
3.12
OS:
Debian 12
Checklist:
Related to #2429