Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: change code for non-escape mode - return url #2426

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

samvova
Copy link
Contributor

@samvova samvova commented Nov 29, 2024

Description

The correction ensures that when escape is False, url is used instead of content in the formatted string.
Issue#2425

Describe your tests

How did you test your change?

from formatting import mlink

print(mlink("content", "http://example.com/test", escape=False))
#[content](http://example.com/test)

print(mlink("content", "http://example.com/test", escape=True))
#[content](http://example\.com/test)

Python version:
3.10
OS:
Windows 11

Checklist:

  • [] I added/edited example on new feature/change (if exists)
  • My changes won't break backward compatibility
  • I made changes both for sync and async

@Badiboy
Copy link
Collaborator

Badiboy commented Nov 29, 2024

Thank you!

@Badiboy Badiboy merged commit 64baf03 into eternnoir:master Nov 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants