Bot API 7.5 #2311
Merged
Bot API 7.5 #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and RevenueWithdrawalState, containing information about Telegram Star transactions involving the bot.
…t of all Telegram Star transactions for the bot.
…eText, editMessageMedia, editMessageCaption, editMessageLiveLocation, stopMessageLiveLocation and editMessageReplyMarkup, allowing the bot to edit business messages.
…lowing the bot to stop polls it sent on behalf of a business account.
|
@Badiboy done, need your review |
|
Got it |
Badiboy
reviewed
Jun 19, 2024
| return None | ||
|
|
||
|
|
||
| class RevenueWithdrawalStatePending(RevenueWithdrawalState): |
There was a problem hiding this comment.
I suppose all these Child classes needs de_json method...
Check BackgroundFill series for equal implementation...
| self.type: str = type | ||
|
|
||
|
|
||
| class TransactionPartner(JsonDeserializable): |
There was a problem hiding this comment.
The same as for RevenueWithdrawalState - de_json for Childs
|
|
||
| def __init__(self, type, user, **kwargs): | ||
| self.type: str = type | ||
| self.user: User = user |
There was a problem hiding this comment.
We need do de_json USER somewhere (in de_json of class, I suppose).
|
If I understood you right - I just forgot all de_json methods for classes |
|
btw, I'm done just in case you missed @Badiboy |
|
LGTM, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bot API 7.5