Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump golang.org/x/tools from 0.25.0 to 0.27.0 in /tools/mod #18873

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 11, 2024

Bumps golang.org/x/tools from 0.25.0 to 0.27.0.

Commits
  • 4d2b19f go.mod: update golang.org/x dependencies
  • 6368677 gopls/internal/golang: strength reduce ComputeImportFixEdits
  • 777f155 gopls/internal/golang: show package attributes on hover
  • 8a0e08f gopls/doc: add missing doc link
  • 61415be gopls/internal/cache: guard against malformed paths in port.matches
  • 9a89d3a internal/analysisinternal: avoid sub-token spans in TypeErrorEndPos
  • 1115af6 internal/expect: support named arguments f(a, b, c=d, e="f")
  • 0b9e499 go/{expect,packages/packagestest}: mention the tag+delete proposal
  • efcd2bd internal/packagestest: fork go/packages/packagestest
  • 0e9ed3d go/packages: do not mutate Config
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 11, 2024
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.66%. Comparing base (e1b4ffb) to head (29d4dae).

Current head 29d4dae differs from pull request most recent head c05d1be

Please upload reports for the commit c05d1be to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18873      +/-   ##
==========================================
- Coverage   68.78%   68.66%   -0.13%     
==========================================
  Files         420      420              
  Lines       35558    35558              
==========================================
- Hits        24459    24416      -43     
- Misses       9672     9707      +35     
- Partials     1427     1435       +8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1b4ffb...c05d1be. Read the comment docs.

Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.25.0 to 0.27.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.25.0...v0.27.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/tools/mod/golang.org/x/tools-0.27.0 branch from b65317c to c05d1be Compare November 14, 2024 21:37
@ivanvc
Copy link
Member

ivanvc commented Nov 17, 2024

Closing, indirect. Refer to https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/dependency_management.md#indirect-dependencies

$ find -name go.mod -exec grep -H golang.org/x/tools {} \;
./tools/mod/go.mod:     golang.org/x/tools v0.25.0 // indirect

@ivanvc ivanvc closed this Nov 17, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 17, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/tools/mod/golang.org/x/tools-0.27.0 branch November 17, 2024 06:29
@ivanvc
Copy link
Member

ivanvc commented Nov 17, 2024

@ArkaSaha30, you should now have triage permissions. Feel free to close these pull requests after merging your dependency PR 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tooling dependencies Pull requests that update a dependency file go Pull requests that update Go code needs-ok-to-test size/M
Development

Successfully merging this pull request may close these issues.

3 participants