Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e test reverse proxy unused functions cleanup #18640

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

e2e test reverse proxy unused functions cleanup #18640

wants to merge 4 commits into from
+0 −326

Commits on Sep 26, 2024

  1. Remove PauseAccept of the reverse proxy from the e2e test 

    Part of the patches to fix etcd-io#17737

During the development of etcd-io#17938,
we agreed that during the transition to L7 forward proxy, unused
features and features targeting L4 reverse proxy will be dropped.

This feature falls under the unused feature.

Signed-off-by: Chun-Hung Tseng <[email protected]>
    @henrybear327
    henrybear327 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    462d24a View commit details
    Browse the repository at this point in the history

  2. Remove DelayAccept of the reverse proxy from the e2e test 

    Part of the patches to fix etcd-io#17737

During the development of etcd-io#17938,
we agreed that during the transition to L7 forward proxy, unused
features and features targeting L4 reverse proxy will be dropped.

This feature falls under the unused feature.

Signed-off-by: Chun-Hung Tseng <[email protected]>
    @henrybear327
    henrybear327 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    925181a View commit details
    Browse the repository at this point in the history

  3. Remove LatencyAccept of the reverse proxy from the e2e test 

    Part of the patches to fix etcd-io#17737

During the development of etcd-io#17938,
we agreed that during the transition to L7 forward proxy, unused
features and features targeting L4 reverse proxy will be dropped.

This feature falls under the unused feature. Also, the initial
implementation has a bug: if connections are not created continuously,
the latency accept will not work. Consider the following case:
a) set latency accept
b) put latency accept into effect
c) latency accept will start idling the goroutine
d) block-wait at accept() - waiting for new connections
e) new connection comes in - establish it
f) go to c -> as we can see, if the request come every x seconds, where
x is larger than the latency accept time we set, we can see that the
latency accept has no effect.

Signed-off-by: Chun-Hung Tseng <[email protected]>
    @henrybear327
    henrybear327 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    fd967e0 View commit details
    Browse the repository at this point in the history

  4. Remove PauseTx and PauseRx of the reverse proxy from the e2e test 

    Part of the patches to fix etcd-io#17737

During the development of etcd-io#17938,
we agreed that during the transition to L7 forward proxy, unused
features and features targeting L4 reverse proxy will be dropped.

This feature falls under the unused feature.

Signed-off-by: Chun-Hung Tseng <[email protected]>
    @henrybear327
    henrybear327 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5fb0352 View commit details
    Browse the repository at this point in the history