-
Notifications
You must be signed in to change notification settings - Fork 645
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This adds a way to compare benchmarks that we use in kube-state-metrics already, hopefully allowing for better comparisons when applying changes. Signed-off-by: Manuel Rüger <[email protected]>
- Loading branch information
Showing
3 changed files
with
81 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
--- | ||
name: Benchmarks on AMD64 | ||
permissions: read-all | ||
on: [push, pull_request] | ||
jobs: | ||
ci-benchmark-tests: | ||
name: ci-benchmark-tests | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Check out code into the Go module directory | ||
uses: actions/checkout@v4 | ||
- id: goversion | ||
run: echo "goversion=$(cat .go-version)" >> "$GITHUB_OUTPUT" | ||
|
||
- name: Set up Go 1.x | ||
uses: actions/setup-go@v5 | ||
with: | ||
go-version: ${{ steps.goversion.outputs.goversion }} | ||
id: go | ||
|
||
- name: Install Benchstat | ||
run: | | ||
make install-benchstat | ||
- name: Benchmark tests | ||
run: | | ||
make test-benchmark-compare |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
#!/usr/bin/env bash | ||
# https://github.com/kubernetes/kube-state-metrics/blob/main/tests/compare_benchmarks.sh (originally written by mxinden) | ||
|
||
# exit immediately when a command fails | ||
set -e | ||
# only exit with zero if all commands of the pipeline exit successfully | ||
set -o pipefail | ||
# error on unset variables | ||
set -u | ||
|
||
[[ "$#" -eq 1 ]] || echo "One argument required, $# provided." | ||
|
||
REF_CURRENT="$(git rev-parse --abbrev-ref HEAD)" | ||
REF_TO_COMPARE=$1 | ||
|
||
RESULT_CURRENT="$(mktemp)-${REF_CURRENT}" | ||
RESULT_TO_COMPARE="$(mktemp)-${REF_TO_COMPARE}" | ||
|
||
echo "" | ||
echo "### Testing ${REF_CURRENT}" | ||
|
||
go test -benchmem -run=NONE -bench=. ./... | tee "${RESULT_CURRENT}" | ||
|
||
echo "" | ||
echo "### Done testing ${REF_CURRENT}" | ||
|
||
echo "" | ||
echo "### Testing ${REF_TO_COMPARE}" | ||
|
||
git checkout "${REF_TO_COMPARE}" | ||
|
||
go test -benchmem -run=NONE -bench=. ./... | tee "${RESULT_TO_COMPARE}" | ||
|
||
echo "" | ||
echo "### Done testing ${REF_TO_COMPARE}" | ||
|
||
git checkout - | ||
|
||
echo "" | ||
echo "### Result" | ||
echo "old=${REF_TO_COMPARE} new=${REF_CURRENT}" | ||
|
||
benchstat "${RESULT_TO_COMPARE}" "${RESULT_CURRENT}" |