impound vehicle to garage, notify the owner, and an error fix #58
Conversation
Goshawk1337
commented
Dec 23, 2024
Goshawk1337
commented
- If a policeman impounds a vehicle it wil l go to the garage, and notify the owner
- if the data.value was nil it was throwing an error, now its fixed and the menu can properly work.
- If a policeman impounds a vehicle it wil l go to the garage, and notify the owner - if the data.value was nil it was throwing an error, now its fixed and the menu can properly work.
server/main.lua
Outdated
| if not state then return end | ||
|
|
||
|
|
||
| ESX.SetStored(plate, state) |
| local response = MySQL.query.await('SELECT `owner` FROM `owned_vehicles` WHERE `plate` = ?', { | ||
| plate | ||
| }) | ||
| if not response then return end |
server/main.lua
Outdated
|
|
||
| RegisterNetEvent("esx_policejob:impoundVehicle") | ||
| AddEventHandler("esx_policejob:impoundVehicle", function(plate, state) | ||
| if GetInvokingResource() then return end |
There was a problem hiding this comment.
What is the point of this? Just confirm the source players job and distance to the entity for validation.
client/main.lua
Outdated
| function ImpoundVehicle(vehicle) | ||
| --local vehicleName = GetLabelText(GetDisplayNameFromVehicleModel(GetEntityModel(vehicle))) | ||
| local plate = ESX.Game.GetVehicleProperties(vehicle).plate |
There was a problem hiding this comment.
This is overkill. Just do
local plate = ESX.Math.Trim(GetVehicleNumberPlateText(vehicle))
client/main.lua
Outdated
| function ImpoundVehicle(vehicle) | ||
| --local vehicleName = GetLabelText(GetDisplayNameFromVehicleModel(GetEntityModel(vehicle))) | ||
| local plate = ESX.Game.GetVehicleProperties(vehicle).plate | ||
| TriggerServerEvent("esx_policejob:impoundVehicle", plate, 2) |
There was a problem hiding this comment.
Pass vehicle netId for validation on the server
|
With all that being said, I am not sure why we should send a vehicle to a players garage when police impounds it. |
there was a todo for it, and i thought i try to do it, which i did, but it did not meet the requirments, also it sends to the impound. |
|
Also sorry, for the many mistakes, i learned everything basically from myself, and i thougth this is a good practice for, me what to do better, as expected there is many thing i can :D |
You good, that's the point of these reviews 👍🏽 Appreciate your contribution |
|
Hi, i made the changes you asked for. |
