-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update CI and add Code Coverage #326
Conversation
Action-rs is archived. Suggest dtolnays action. Check out our situation in trace4rs. I think that's the way to do it until we understand the future of actions-rs. |
Treat this as a draft for now. I don't love that coverage has to go outside the PR. |
Understood that action-rs was deprecated recently, but at this time I don't see a better alternative. I swapped the toolchain checkout though. |
Suggestions: https://github.com/dtolnay/rust-toolchain to install cargo, clippy fmt etc, then just: steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- run: cargo test --all-features
- run: cargo nextest --all-features
- run: cargo clippy
- run: cargo fmt
- etc etc |
@estk Hmm seems that both our configs and the github actions configs aren't processed well by the editor config. Situations such as - kind: threshold
level: error can't be processed properly because the indent level isn't a multiple of 4. Do we want to disable the check for yaml files? I can do some further research to see if we can work around it another way. |
I think we just need to fix the files. |
@estk What I'm saying is that we would need to define a new configuration format (and the gitlab actions format) to fix the job. When I try to fix the indentation locally and run the unit tests I see the following: ---- config::raw::test::full_deserialize stdout ----
thread 'config::raw::test::full_deserialize' panicked at src/config/raw.rs:492:63:
called `Result::unwrap()` on an `Err` value: Error { kind: SCANNER, problem: "mapping values are not allowed in this context", problem_mark: Mark { line: 9, column: 18 } }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace |
@estk Looks like the final action is setting up the main repo for codecov.io which I can't do |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
42d6526
to
b4d882c
Compare
Hey @bconn98 , thanks for this, I think we're in the home stretch. Regarding raw.rsThis will be a recurring problem for yaml files that are embedded in rust files. I think one way we can fix this permanently is to disable indentation checks for .rs files since it will already be covered by rustfmt. [*.rs]
indent_size = false |
b4d882c
to
012ad79
Compare
@estk done |
No description provided.