Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump deps #319

Merged
merged 1 commit into from
Nov 29, 2023
Merged

chore(deps): Bump deps #319

merged 1 commit into from
Nov 29, 2023

Conversation

Dirreke
Copy link
Contributor

@Dirreke Dirreke commented Nov 26, 2023

Glad to see the PR moving again.
This PR will bump a series of dependencies.

Bump arc-swap from 1.2 to 1.6.
Bump humantime from 2.0 to 2.1.
Bump serde_yaml from 0.8.4 to 0.9.
Bump toml from 0.5 to 0.8.
Bump parking_lot from 2.0 to 2.1.
Bump derivative from 2.1.1 to 2.2.
Bump tempfile from 3.1.0 to 3.8.

@westy92
Copy link
Contributor

westy92 commented Nov 28, 2023

I was about to do this. Thanks for beating me to it!

@estk
Copy link
Owner

estk commented Nov 28, 2023

rebase please

@westy92
Copy link
Contributor

westy92 commented Nov 28, 2023

We also might need to bump MSRV.

@westy92
Copy link
Contributor

westy92 commented Nov 28, 2023

Toml needs 1.67

@Dirreke
Copy link
Contributor Author

Dirreke commented Nov 28, 2023

Is it ok if I bump MSRV in this PR?

@estk
Copy link
Owner

estk commented Nov 28, 2023

My thinking with MSRV is that I like to have a release that is ~ 1yr old. These bits will take some time to release so I think 1.67 is fine.

@estk
Copy link
Owner

estk commented Nov 28, 2023

Actually, now that I think of it, let's do 1.66, you'll need to update the CI as well.

@Dirreke
Copy link
Contributor Author

Dirreke commented Nov 29, 2023

I try to use 1.66 and I found it doesn't make any sense, because serde_spanned and toml_datetime, which are the dependencies of toml both required MSRV 1.67 unless I keep toml to 0.5(then we don't need to bump MSRV).

Another choice is that we can add both serde_spanned and toml_datetime to the dependencies of log4rs and restrict the version of them.

What do you think about it?

@Dirreke
Copy link
Contributor Author

Dirreke commented Nov 29, 2023

I also changed the wrong key rust to rust-version.

@estk
Copy link
Owner

estk commented Nov 29, 2023

Im calling this good

@estk estk merged commit de3d6c8 into estk:master Nov 29, 2023
9 checks passed
@bconn98
Copy link
Collaborator

bconn98 commented Nov 30, 2023

FYI @estk @Dirreke in the future make sure to bump the version listed in the README as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants