-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(encode/pattern): add debug and release formatters #301
Conversation
@estk Recommended for merge |
Thanks for having a look at this PR:) |
@SteveLauC excellent work, @bconn98 thanks for reviewing this. @SteveLauC can you write some super simple tests just verifying in debug and release mode things work as expected? |
fa2c4ba
to
12650f7
Compare
12650f7
to
eba7f9f
Compare
Test added, commits squashed |
eba7f9f
to
747a4ea
Compare
Quick check from mobile and kicking off the tests on my build server look good 👍🏻 |
Lgtm with one exception, we need to build and run this test in CI. Maybe add another line to the Test action that does a 'cargo test --release --features simple_writer yourtestfile -- yourtestname' |
747a4ea
to
32d9c46
Compare
I recommend enabling CI even for first-time-contributors so that we can check if it works as expected |
@SteveLauC Branch is out of date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just needs conflicts resolved then gtg
32d9c46
to
eb79f7a
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 61.17% 61.23% +0.06%
==========================================
Files 23 23
Lines 1383 1406 +23
==========================================
+ Hits 846 861 +15
- Misses 537 545 +8 ☔ View full report in Codecov by Sentry. |
Rebased |
Fixes #300
What this PR does:
D
/debug
andR
/release
pattern formatters.