Skip to content
This repository has been archived by the owner on Nov 7, 2024. It is now read-only.

Removed application style sheet #1048

Merged
merged 10 commits into from
Dec 6, 2023
Merged

Removed application style sheet #1048

merged 10 commits into from
Dec 6, 2023

Conversation

ggoneiESS
Copy link
Member

Issue

Light mode macoS meant labels were not visible. This fix had been implemented before but reverted at some point. It should be checked in a native Linux environment.

Description of work

The set style method of Qt was removed

Acceptance Criteria

All labels/buttons should be readable

UI tests

UI tests do not pick up on this change

Nominate for Group Code Review

  • Nominate for code review

@ggoneiESS ggoneiESS self-assigned this Nov 29, 2023
@ggoneiESS ggoneiESS requested review from zjttoefs and hurvan November 30, 2023 13:38
@hurvan
Copy link
Contributor

hurvan commented Dec 4, 2023

Things look normal and readable on my ubuntu 22.04 machine.

Copy link
Contributor

@hurvan hurvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ggoneiESS ggoneiESS merged commit 8e0ce3e into main Dec 6, 2023
8 checks passed
@ggoneiESS ggoneiESS deleted the Colour-Fix-Across-OSes branch December 6, 2023 07:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants