This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
ECDC-3526-NXtransformations_offsets #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggoneiESS
commented
Oct 13, 2023
danesss
suggested changes
Oct 13, 2023
There was a problem hiding this comment.
The idea looks good. 👍
I left a few comments and a couple of things that probably need fixing.
Unless you want specific input during the process, in general I think it is best to ask for a review when you have finished making changes and tests are passing. Otherwise we are reviewing changes but we don't know if they work or need further changes. If changes are needed, we have to repeat the review which is a duplication of work 😄
…rmations_offsets' into ECDC-3526-NXtransformations_offsets
danesss
approved these changes
Oct 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This fixes the main part of ticket ECDC-3526, transforming offset into a three-valued vector that is used properly for rotations and translations. It also fixes the GUI to remove some superfluous boxes for the magnitude.
Outstanding from the PR is the smaller issues described in the ticket. This will be pushed into another
Description of work
The offset is used at multiple points as a single-valued point that 'adds on' to whatever the magnitude is. This is incorrect and so the maths has been cleared up. More detailed information for this can be found in the ticket.
Acceptance Criteria
Existing JSON test files may no longer work due to the offset change being altered. Instead a simple component should be made and the effect of application of different offsets, vectors, and magnitudes, should be tested until the satisfaction of the reviewer.
UI tests
N/A
Nominate for Group Code Review