This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
Change to orbit camera as Constructor does not need to run Doom #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code is fine and I tested it manually, it seems to work fine. As I mentioned, I believe it is a good idea to check with the rest of the group before merging this, as it's a change to how the nexus-constructor works. |
amues
approved these changes
Sep 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The viewer for the Constructor uses a first person shooter-style camera. Since we only need to process JSON that creates instruments etc., rather than play DOOM, this is stupid. We use Orbit instead.
Description of work
Changed to QOrbitCameraController class from Qt3DExtras
Acceptance Criteria
Easier to use than before
UI tests
N/A
Nominate for Group Code Review