-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-initialize PSRAM #2546
Auto-initialize PSRAM #2546
Conversation
skip-changelog because of a change I made to esp-alloc, which is inside a macro so it shouldn't be user observable. Except it's breaking because it relies on breaking changes in esp-hal 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(still) works fine
33905bf
to
b62c16f
Compare
5ac821d
to
b059d6d
Compare
Not sure if this is the right place to bring this up but if static linking and/or XiP from PSRAM are still going to be a thing, the auto-initialization would (eventually) be moved out of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This allows removing the locking around reading the memory range.