Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-initialize PSRAM #2546

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Auto-initialize PSRAM #2546

merged 1 commit into from
Nov 23, 2024

Conversation

bugadani
Copy link
Contributor

This allows removing the locking around reading the memory range.

@bugadani bugadani added the skip-changelog No changelog modification needed label Nov 15, 2024
@bugadani
Copy link
Contributor Author

skip-changelog because of a change I made to esp-alloc, which is inside a macro so it shouldn't be user observable. Except it's breaking because it relies on breaking changes in esp-hal 🤔

@bugadani bugadani marked this pull request as ready for review November 15, 2024 15:33
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(still) works fine

@bugadani bugadani marked this pull request as draft November 20, 2024 10:56
@bugadani bugadani marked this pull request as ready for review November 21, 2024 09:46
@Dominaezzz
Copy link
Collaborator

Not sure if this is the right place to bring this up but if static linking and/or XiP from PSRAM are still going to be a thing, the auto-initialization would (eventually) be moved out of esp_hal::init to somewhere before main right?

esp-hal/src/soc/psram_common.rs Outdated Show resolved Hide resolved
esp-hal/src/soc/psram_common.rs Outdated Show resolved Hide resolved
esp-hal/src/soc/psram_common.rs Outdated Show resolved Hide resolved
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev added this pull request to the merge queue Nov 23, 2024
Merged via the queue into esp-rs:main with commit fe482bd Nov 23, 2024
28 checks passed
@bugadani bugadani deleted the psram branch November 23, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants