Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CI): Move CI to Github Actions #71

Merged
merged 16 commits into from
Nov 14, 2024
Merged

Conversation

samoehlert
Copy link
Collaborator

Closes: #50

Moving to Github Actions allows for better external collaboration as well as just a pure speed increase. This also means we can remove the dependency on Gitlab CI. We did remove a few of the built in processes from Gitlab CI file, but that's because we could turn on things in the settings directly (secret scanning and dependency scanning as well as Code Quality/SAST).

@samoehlert samoehlert added the enhancement New feature or request label Nov 12, 2024
.github/workflows/docs.yml Show resolved Hide resolved
.github/workflows/flake8.yml Outdated Show resolved Hide resolved
.github/workflows/pytest.yml Show resolved Hide resolved
works in conjunction with the if on the last step to run always, excpet only publish the docs on the main branch
Copy link

github-actions bot commented Nov 14, 2024

File Coverage
All files 90%
manage.py 56%
config/asgi.py 36%
config/consumers.py 83%
config/urls.py 82%
config/settings/base.py 74%
config/settings/local.py 87%
scram/contrib/sites/migrations/0003_set_site_domain_and_name.py 90%
scram/route_manager/authentication_backends.py 94%
scram/route_manager/models.py 88%
scram/route_manager/views.py 69%
scram/route_manager/api/serializers.py 95%
scram/route_manager/api/views.py 86%
scram/route_manager/tests/test_websockets.py 85%
scram/route_manager/tests/acceptance/steps/common.py 75%
scram/route_manager/tests/acceptance/steps/ip.py 70%

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 413e2dc

@samoehlert samoehlert marked this pull request as ready for review November 14, 2024 03:39
@samoehlert samoehlert marked this pull request as draft November 14, 2024 03:40
grigorescu
grigorescu previously approved these changes Nov 14, 2024
@samoehlert samoehlert marked this pull request as ready for review November 14, 2024 15:52
Copy link
Collaborator

@crankynetman crankynetman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, nice work!

@samoehlert samoehlert merged commit de3d2b5 into develop Nov 14, 2024
8 of 9 checks passed
@samoehlert samoehlert deleted the topic/soehlert/github_ci branch November 14, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move CI to Github
3 participants