Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation New Guides & Updates for 1.4.0 - Round 1 #200

Merged
merged 49 commits into from
Jun 18, 2024

Conversation

alliomeria
Copy link
Contributor

@alliomeria alliomeria commented Jun 18, 2024

New Guides:

  • wacz_page_extractor and webpage post-processor
  • warc_to_wacz post-processor
  • subtitle post-processor
  • IIIF Server Configuration Forms
  • IIIF Content Search API
  • Core Documentation Guides

Updates for:

@alliomeria alliomeria added documentation Improvements or additions to documentation enhancement New feature or request Release Duties Release and Github cleanups labels Jun 18, 2024
@alliomeria alliomeria added this to the 1.4.0 milestone Jun 18, 2024
@alliomeria alliomeria requested a review from DiegoPino June 18, 2024 15:27
Copy link
Member

@DiegoPino DiegoPino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alliomeria this is really good stuff!! I left a few comments around (mostly comments/ideas/some give or take..) and a note about OCR settings/pager settings on the subtitle one that do not apply I think, might be just left overs of a previous copy. Please feel free to tackle (if) my comments after the Holiday. Thanks so much for your work! 🥇

docs/101_guides_list.md Show resolved Hide resolved

!!! warning "Adding New Facets"

The default Facets available through Archipelago's Advanced Batch Find and Replace have an important configuration selection made on each individual Facet. For every [new Facet you add](strawberry_key_name_providers.md) for Find and Replace, you need to select the checkboxes for both the 'VBO batch handler' settings to use the `VBO Batch Facet processor`, and the selection within the 'VBO batch handler settings' to `Use URL based facets in VBO Batches`. You need to make sure these are selected so that the "visible" list/count of objects you filter using a Facet is respected during actual VBO process execution of batch changes you make for any Find and Replace Actions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Here is a missing need/documentation part that needs to be added. VBO does not pass a "limit" (except if your VIEW has actually a "SHOW" a defined number of results which most users will never use. Because of that, when run will default to the Search API/Solr defined Limit. At
http://localhost:8001/admin/config/search/search-api/server/esmero_solr/edit (under the advanced tab). Which means if you see 1000 objects In your Find and Replace and select all and run IT and that value here is 100, only 100 will be processed. Nothing we can do around that (for now, except open an ISSUE, tag me, maybe we can find a way). We need a note for that 🐝 !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, added an additional statement about this behavior, using some of the language you shared in your above comment. Let me know what think @DiegoPino

docs/iiif-content-search.md Outdated Show resolved Hide resolved
docs/iiif-content-search.md Show resolved Hide resolved
docs/iiif_server_settings.md Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
docs/strawberryrunners_subtitle.md Outdated Show resolved Hide resolved
docs/strawberryrunners_subtitle.md Outdated Show resolved Hide resolved
docs/strawberryrunners_subtitle.md Outdated Show resolved Hide resolved
docs/webformsasinput.md Outdated Show resolved Hide resolved
@alliomeria
Copy link
Contributor Author

Thanks for your review and feedback @DiegoPino! I incorporated some small changes based on your comments, resolved most comments, and left a couple for you re: VBO limit note and IIIF Config Form Snippet example (I did the 'service' snippet to the IIIF Content Search API doc as recommended). Please let me know what you think and if/when I'm clear to merge this batch of new and updates docs. 🤓

@DiegoPino
Copy link
Member

@alliomeria you totally free to merge. We have not yet enabled the automatic Github pages trigger for 1.4.0 so we have a few days more of slack in case you find anything you want to change. All looks good/awesome to me. I might need fresher eyes though to re-read all the extra things you added and add emojis here and there. Thanks again for your hard work on these.

@alliomeria
Copy link
Contributor Author

Ok great, I will merge in just a few moments. Yes, we don't yet have the 1.4.0 public docs site syncing setup just yet. No worries, that's on my Friday tasks to setup and push a test for. :)

@alliomeria alliomeria merged commit 3481c68 into esmero:1.4.0 Jun 18, 2024
@DiegoPino
Copy link
Member

Woho!

@alliomeria alliomeria changed the title Documentation New Guides & Updates for 1.4.0 Documentation New Guides & Updates for 1.4.0 - Round 1 Jun 18, 2024
alliomeria added a commit to alliomeria/archipelago-documentation that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request Release Duties Release and Github cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants