Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update I7solrImporter.md #140

Merged
merged 8 commits into from
Nov 29, 2022

Conversation

karomabiles
Copy link
Contributor

Document has been updated through Step 7. All screenshots have been updated using local version 1.0.0 (can clean those up if needed). Any suggestions on where to place Screenshot version language - All screenshots were created using Archipelago version 1.0.0 of local instance?

Document has been updated through Step 7. All screenshots updated using local version 1.0.0
@alliomeria
Copy link
Contributor

This is looking great so far @karomabiles! Will hold off on merging until you pass the additional updates for the images and carry over any applicable sections related to Processing from the updated AMIviaSpreadsheets.md in PR#143.

@aksm
Copy link
Contributor

aksm commented Nov 29, 2022

Document has been updated through Step 7. All screenshots have been updated using local version 1.0.0 (can clean those up if needed). Any suggestions on where to place Screenshot version language - All screenshots were created using Archipelago version 1.0.0 of local instance?

@karomabiles, maybe a note admonition at the top or else image captions on each image?

@DiegoPino
Copy link
Member

@aksm we can add a second pull for the note about the versions. I want to discuss that with you all (Maybe after the workshop) because these screenshots are of AMI 0.5.0 (means in-between versions) and that is OK.

@alliomeria
Copy link
Contributor

Looks great @karomabiles! @DiegoPino, think this is good to go now!

@alliomeria
Copy link
Contributor

(links double-checked and corrected live by @karomabiles) 😺

@DiegoPino DiegoPino merged commit 330de28 into esmero:1.0.0 Nov 29, 2022
@alliomeria alliomeria mentioned this pull request Nov 29, 2022
18 tasks
@alliomeria alliomeria linked an issue Nov 29, 2022 that may be closed by this pull request
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Updates (Macro)
4 participants