Fix node builtin modules imports (close #566)

esm-dev · Mar 25, 2023 · 8f261b7 · 8f261b7
1 parent 2f8e28c
commit 8f261b7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/server/build.go b/server/build.go
@@ -736,7 +736,10 @@ esbuild:
 					if cjsContext {
 						p = bytes.TrimPrefix(p, []byte{')'})
 						var marked bool
-						if _, ok := builtInNodeModules[name]; !ok {
+						if builtInNodeModules[name] {
+							cjsImportNames.Add("default")
+							marked = true
+						} else {
 							depPkg, _, err := validatePkgPath(name)
 							depWd := task.wd
 							if err == nil && !fileExists(path.Join(depWd, "node_modules", depPkg.Name, "package.json")) {

diff --git a/test/issue-566/issue-566.test.ts b/test/issue-566/issue-566.test.ts
@@ -0,0 +1,7 @@
+import { assertEquals } from "https://deno.land/[email protected]/testing/asserts.ts";
+
+import { Expo } from "http://localhost:8080/[email protected]";
+
+Deno.test("issue #566", () => {
+  assertEquals(typeof Expo, "function");
+});