Modernise #69
Merged
Modernise #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelsonVides
force-pushed
the
modernise
branch
from
435add5
to
697e08a
Compare
arcusfelis
reviewed
Jan 12, 2024
src/exml_query.erl
Outdated
| %% @doc Gets the element/attr/cdata in the leftmost possible described path, | ||
| %% or `Default' if there is no match. | ||
| %% | ||
| %% Find an element in the xml tree by a path that is pattern-matched against such xml tree structure |
There was a problem hiding this comment.
Suggested change
| %% Find an element in the xml tree by a path that is pattern-matched against such xml tree structure | |
| %% Find an element in the xml tree by a path that is pattern-matched against such xml tree structure. |
same below
| to_iolist([Element], Pretty) -> | ||
| to_iolist(Element, Pretty); | ||
| to_iolist([#xmlstreamstart{name = Name, attrs = Attrs} | Tail] = Elements, Pretty) -> | ||
| [Last | RevChildren] = lists:reverse(Tail), |
There was a problem hiding this comment.
Suggested change
| [Last | RevChildren] = lists:reverse(Tail), | |
| %% Add extra nesting for streams so pretty-printing would be indented properly | |
| [Last | RevChildren] = lists:reverse(Tail), |
src/exml_stream.erl
Outdated
| %% Parser options | ||
| %% | ||
| %% <ul> | ||
| %% <li>`infinite_stream': No distinct `t:start()' or `t:stop()', only #xmlel{} will be returned.</li> |
There was a problem hiding this comment.
Suggested change
| %% <li>`infinite_stream': No distinct `t:start()' or `t:stop()', only #xmlel{} will be returned.</li> | |
| %% <li>`infinite_stream': No distinct `t:start()' or `t:stop()', only `#xmlel{}' will be returned.</li> |
NelsonVides
force-pushed
the
modernise
branch
2 times, most recently
from
2823881
to
880c508
Compare
NelsonVides
force-pushed
the
modernise
branch
from
880c508
to
3df87ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly docs improvements and newer erlang in CI, only one optimisation in code in the printing function.