Several minor benchmarking changes (facebook#3196)

Summary: This diff * Changes some Pandas indexing to avoid a "setting with copy" warning * Corrects the docstring of `BenchmarkTrialMetadata` * Renames `ModelLauncherProblem` to `ModelLauncherTestFunction`, since it is a test function and not a problem Differential Revision: D67419032
esantorella · Dec 18, 2024 · 13aeb72 · 13aeb72
1 parent 441a236
commit 13aeb72
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ax/benchmark/benchmark_metric.py b/ax/benchmark/benchmark_metric.py
@@ -198,7 +198,7 @@ def fetch_trial_data(self, trial: BaseTrial, **kwargs: Any) -> MetricFetchResult
             available_data = df[df["virtual runtime"] <= max_t]
 
         if not self.observe_noise_sd:
-            available_data["sem"] = None
+            available_data.loc[:, "sem"] = None
         return self._df_to_result(df=available_data.drop(columns=["virtual runtime"]))
 
     @abstractmethod

diff --git a/ax/benchmark/benchmark_trial_metadata.py b/ax/benchmark/benchmark_trial_metadata.py
@@ -20,7 +20,7 @@ class BenchmarkTrialMetadata:
 
     Args:
         df: A dict mapping each metric name to a Pandas DataFrame with columns
-            ["metric_name", "arm_name", "mean", "sem", and "t"]. The "sem" is
+            ["metric_name", "arm_name", "mean", "sem", and "step"]. The "sem" is
             always present in this df even if noise levels are unobserved;
             ``BenchmarkMetric`` and ``BenchmarkMapMetric`` hide that data if it
             should not be observed, and ``BenchmarkMapMetric``s drop data from