Fix Deployment for macOS x86_64 wheels on PyPi #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub Runner is arm64-based: - cross-compiling with GNU/GCC does not work - only Apple Clang + TBB requires C++17 - Hence minimal deployment target macOS 10.13 (release 2017) - Discontinuance support for macOS < 10.13 (pre-2017)
schuhmaj
changed the title
schuhmaj
changed the title
|
@gomezzz One more review for JOSS fixing macOS again. I don't say it's the last anymore - this has been proven way too often wrong 🥲 |
spdlog 1.14.1 an 1.14.0 are not yet available on conda-forge. This might cause issues for the conda-deployment otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
STATUS RELEASE CANDIDATE 3.2rc1
The macOS x86_64 wheel deployment also broke. It seems that the runner is now using the
arm64architecture.The current set-up using
gccis no longer applicable as it does not allow cross-compiling. Hence, we need to use Apple Clang, as in thearm64based approach.Our dependency TBB requires C++17. Hence, the minimal deployment target for macOS x86_64 is now
macOS 10.13, released in 2017, from which point Apple Clang and friends support C++17. The support for older versions is dropped (previously, the target was10.9) - at least for releases onPyPi,condawill still build for10.9and newer (since it uses OpenMP for parallelization and omits the TBB dependency).Minor stuff along the way
3.2so that the JOSS release has a round numberUff, I never release again, thinking no code changes will lead to smooth deployment... the CI/ CD environment could also change, as it happened