Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jmh refactor package #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Jmh refactor package #3

wants to merge 3 commits into from

Conversation

egry35
Copy link

@egry35 egry35 commented Aug 22, 2016

several modifications :

  • add package to java class : default package to com.ertu.collection (get from groupid in pom.xml)
  • add getter on several fields
  • add JMH benchmark (with tests included in Benchmark file)
  • update readme.md

@egry35
Copy link
Author

egry35 commented Oct 6, 2016

hello,

why do you closed the pull request ? I don't see the merged pull request in master branch.

regards,

@ertugrulcetin ertugrulcetin reopened this Mar 3, 2017
@ertugrulcetin
Copy link
Owner

@egry35 Could you just add jmh benchmarks please? So it will be easy for me to reason about.Since you've added lots of changes the code. I can't clearly understand what is going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants