Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix allows yaws to receive data over 64MB in size.
open an erlang shell, start a tcp listener, send 256M + 1B and connect to it with:
spawn(fun() ->
{ok,LS} = gen_tcp:listen(3456,[{reuseaddr, true}, {active, false}, binary]),
{ok,SS} = gen_tcp:accept(LS),
gen_tcp:send(SS,crypto:strong_rand_bytes((4 * 64 * 1024 * 1024) + 1)),
receive stop -> ok end
end).
{ok,RS} = gen_tcp:connect("localhost",3456,[{reuseaddr, true}, {active, false}, binary]).
then on the receive side note that this can only be consumed in chunks of 64MB or less:
gen_tcp:recv(SS, (64 * 1024 * 1024) + 0, 1000).
gen_tcp:recv(SS, (64 * 1024 * 1024) + 1, 1000).
gen_tcp:recv(RS, (64 * 1024 * 1024) + 0, 1000).
gen_tcp:recv(RS, (64 * 1024 * 1024) + 1, 1000).
gen_tcp:recv(RS, (64 * 1024 * 1024) + 0, 1000).
gen_tcp:recv(RS, (64 * 1024 * 1024) + 1, 1000).
gen_tcp:recv(RS, (64 * 1024 * 1024) + 0, 1000).
gen_tcp:recv(RS, (64 * 1024 * 1024) + 1, 1000).
gen_tcp:recv(RS, 1, 1000).
in our application all uploads of files greater than 64MB fail with enomem in the same way as demonstrated here.
this change works in our application at least.