Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript definitions for v5. #270

Open
wants to merge 1 commit into
base: 5.0
Choose a base branch
from

Conversation

gilbsgilbs
Copy link

Fixes #223

Maybe not the most accurate definition, but works in my case. Unlike what I thought at first, it seems exhaustive (given that there's less components in v5 at the moment). Also, I'm pretty sure this doesn't follow best practices in term of dependency typing. Let me know if there's something I can do to improve.

@codecov
Copy link

codecov bot commented Jul 25, 2018

Codecov Report

Merging #270 into 5.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              5.0     #270   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           8        8           
  Lines          24       24           
=======================================
  Hits           16       16           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9328e93...d16c079. Read the comment docs.

@diegolaciar
Copy link

@erikras, would be very nice to have TS def in your project! :)
@gilbsgilbs thanks for this PR

@gilbsgilbs
Copy link
Author

@diegolaciar If this doesn't move much, we can make a PR to DefinitelyTyped instead. But this project doesn't seem maintained anymore unfortunately. PR and issues remains staled and v5 still isn't out although MUI 1.0 was released quite some time ago and prior versions of MUI are deprecated (I'm not even sure they're still supported).

@alathon
Copy link

alathon commented Mar 4, 2019

@gilbsgilbs Did you ever make a PR to DefinitelyTyped ?

@gilbsgilbs
Copy link
Author

gilbsgilbs commented Mar 4, 2019

@alathon Thanks for asking. No I didn't and I don't think I'll make it unless I have a substantial proof that this project is not abandonware. You can make a PR to DefinitelyTyped yourself if you really want 🙌 .

@alathon
Copy link

alathon commented Jun 19, 2019

@gilbsgilbs Yeah, we've since moved to something else as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants