Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No boost #1288

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

No boost #1288

wants to merge 29 commits into from

Conversation

davidsummers
Copy link

This addresses the first part of issue #1287 by removing the boost formatting and program_options dependencies.

This is just a quick hack. I'm sure there are better ways to do it but this works.

Please review and let me know if other ways to do it are required to have this accepted into the range-v3 project.

@davidsummers
Copy link
Author

davidsummers commented Aug 27, 2019

This is still a work in progress.

I've accomplished part 1 of Issue #1287 and I'm working on trying to replace the BOOT date with the date library date::sys_days.

If anyone has any ideas on how to do that I would really appreciate knowing how to accomplish the second goal.

So far I've tried two approaches and neither one work. (See the issue for the details).

David Summers and others added 11 commits August 28, 2019 00:55
…the iota functions. Don't know why. Please help me understand why the compiler doesn't think that CalDate is incrementable. I can do a ++ operation on it with no problem.
… an 'int-like' interface such that we can do both integer ranges and date::year_month_day processing. Code compiles but there is something causing it to crash that I'm investigating.
Fix day formatting.
Truncate lines to length 22 in format_weeks.

Calendar now works without BOOST!
@davidsummers
Copy link
Author

With the last commit, I now have a working calendar example program without the requirement for BOOST.

Please consider merging this into the master branch and what changes to this code would be required to accomplish that.

This was just a quick hack and I'm sure there are probably better ways to do it but this works.

@davidsummers
Copy link
Author

davidsummers commented Sep 29, 2019

How do I figure out how to fix the failed checks?

I think at one point everything showed as working.

I assume changes since then now cause the checks to fail?

How to fix?

@ericniebler
Copy link
Owner

I don't want to drop a full date/time library into the examples/ directory. I would love to see this example use @HowardHinnant's date library, or standard facilities when available. I'm not sure what the options are for downloading it and/or taking a dependency on it.

I would be perfectly OK with dropping the dependency on a library for command line argument parsing.

@JohelEGP
Copy link
Contributor

JohelEGP commented Dec 4, 2019

CMake's file(DOWNLOAD) can do the job here.

@ericniebler
Copy link
Owner

I have also had success with ExternalProject_Add (include(ExternalProject)) before.

@JohelEGP
Copy link
Contributor

JohelEGP commented Dec 4, 2019

FetchContent would be preferable to ExternalProject, but it was added in CMake 3.11. Since only a header is needed, file(DOWNLOAD) is saner than the dance needed to please ExternalProject usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants