BLD: Pin swig<4.3.0 #1281
Merged
BLD: Pin swig<4.3.0 #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## version-3.9.x #1281 +/- ##
================================================
Coverage ? 80.03%
================================================
Files ? 98
Lines ? 13681
Branches ? 2060
================================================
Hits ? 10949
Misses ? 1998
Partials ? 734 ☔ View full report in Codecov by Sentry. |
jcrivenaes
reviewed
Dec 9, 2024
| @@ -23,7 +23,7 @@ | |||
| "metadata": {}, | |||
| "outputs": [], | |||
| "source": [ | |||
| "reekfile = '../xtgeo-testdata/3dgrids/reek/REEK.EGRID'\n", | |||
| "reekfile = \"../xtgeo-testdata/3dgrids/reek/REEK.EGRID\"\n", | |||
There was a problem hiding this comment.
Weird RUFF rule here; I think the former looks nicer to read
jcrivenaes
approved these changes
Dec 9, 2024
|
It might be a good idea to restrict it. I'm hoping that these 3.9.x hot fixes won't be necessary at all anymore soon, so might hold off until the presumptive never-next-time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will create a new 3.9.x version, NOT a 4.0 version where this change has already been made. It is specific to Python 3.8.
Includes a second commit to pass the latest ruff.
See: #1275 #1277