Avoid assuming inplace units + support descriptions of any column. #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
blocked by equinor/webviz-config#199 |
VincentNevermore
pushed a commit
to VincentNevermore/webviz-subsurface
that referenced
this pull request
Jul 19, 2022
* Add hook for updating state through patches * Update python example to hold the map state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #388
This is a proposed solution, not sure if it is the best way to do it, but all units should at least by moved out of the default
volume_terminology.json.The proposed solution also supports descriptions for other column labels than those in the current
volume_terminology.json,and any input description will be prioritized if the column label exist in both input and the default group.
Easy to expand from the current
descriptionandunitif additional metadata options are needed in the future.A similar solution can e.g. be used for UDQ descriptions in #321, and maybe also to allow metadata for the Eclipse vectors in
ReservoirSimulationTimeseries,ReservoirSimulationTimeseriesOneByOneandReservoirSimulationTimeseriesRegionalwhile using aggregated/csv-exported data (not directly from UNSMRY).All of them are basically dependent on whether we think a dictionary stored in a json-file is the way to go for such metadata, think we should be fairly consistent once we have decided on something.
Also see: equinor/webviz-subsurface-testdata#47 for data and setup.