Simulation metadata #323
Merged
Simulation metadata #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asnyv
force-pushed
the
metadata
branch
2 times, most recently
from
7ec5f7e to
48afc8c
Compare
anders-kiaer
requested changes
Apr 28, 2020
webviz_subsurface/plugins/_reservoir_simulation_timeseries_onebyone.py
Outdated
Show resolved
Hide resolved
Comment on lines
556
to
557
| def get_unit(smry_meta, vec): | ||
| return "" if smry_meta is None else simulation_unit_reformat(smry_meta.unit[vec]) |
There was a problem hiding this comment.
Would it be simpler/better that this returns None when there is no unit, instead of empty string?
There was a problem hiding this comment.
It is probably "better", and was considering it, but empty string is "safer" in the sense that no errors are thrown if you don't include None handling each place the get_unit is used. Quite easy to change it still, so I can if you want me to.
There was a problem hiding this comment.
Vote for changing to None. Then I guess it would also be easy to distinguish between missing/undefined unit, and a unit-less quantity/ratio?
There was a problem hiding this comment.
👍 will do. And yes, that should be easy.
|
equinor/resdata#707 merged upstream |
asnyv
force-pushed
the
metadata
branch
2 times, most recently
from
3fa323a to
ff9ddc0
Compare
anders-kiaer
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #284.
The "more robust vector vs node name split" was not done, as it seems like
fmu_ensemble/libecldoesn't support all the properties of vector names that we use (especially for region keywords). Think our existing solution is the best we could hope for atm.Some improvements have also been made to the vector type identification (
is_rate/is_total) upstream in libecl. but the code is not dependent on these changes.Will also improve the
is_historicalflag when this issue is completed . Should be pretty straight forward as long as we get the ideas "approved".Since a lot of the modifications were related to vectors and units, I tried to keep #296 in the back of my head. Point 1 and 2 in #296 is therefore solved in this PR.
Also extended list of "human readable units" from the Eclipse
METRICunit format