linting pylint 2.5.0 (#325)

equinor · Apr 27, 2020 · 843bda0 · 843bda0
1 parent 708b195
commit 843bda0
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/.github/workflows/webviz-subsurface.yml b/.github/workflows/webviz-subsurface.yml
@@ -73,6 +73,7 @@ jobs:
       run: pip freeze
 
     - name: Check code style & linting
+      if: matrix.pandas-version == '1.*'
       run: |
         black --check webviz_subsurface tests setup.py
         pylint webviz_subsurface tests setup.py

diff --git a/webviz_subsurface/_datainput/xsection.py b/webviz_subsurface/_datainput/xsection.py
@@ -173,6 +173,7 @@ def _plot_well_traj(self, zvals, hvals):
 
         # ax.plot(hvals_copy, zvals_copy, linewidth=6, c="black")
 
+    # pylint: disable-too-many-locals
     def _plot_well_zlog(self, df, zvals, hvals, zonelogname, zomin=-999):
         """Plot the zone log as colored segments."""
 
@@ -271,7 +272,7 @@ def _plot_marginal_log(self, df, zvals, hvals, logname, row=1):
                 1,
             )
 
-    # pylint: disable=too-many-locals
+    # pylint: disable=too-many-locals, unused-argument
     def plot_cube(
         self,
         cube=None,
@@ -337,7 +338,7 @@ def plot_cube(
             1,
         )
 
-    # pylint: disable=too-many-locals
+    # pylint: disable=too-many-locals, unused-argument
     def plot_grid3d(self, vmin=None, vmax=None, alpha=0.7):
         """Plot a sampled grid with gridproperty backdrop.
 

diff --git a/webviz_subsurface/plugins/_running_time_analysis_fmu.py b/webviz_subsurface/plugins/_running_time_analysis_fmu.py
@@ -478,11 +478,11 @@ def render_parcoord(plot_df, params, theme, colormap, color_col, colormap_labels
                     "len": 0.3,
                 },
             },
-        ),
+        )
     else:
         data["line"].update(  # pylint: disable=expression-not-assigned
             {"colorbar": {"title": "Running time", "xanchor": "right", "x": -0.02,},},
-        ),
+        )
 
     layout = {}
     layout.update(theme["layout"])

diff --git a/webviz_subsurface/plugins/_surface_viewer_fmu.py b/webviz_subsurface/plugins/_surface_viewer_fmu.py
@@ -9,11 +9,11 @@
 from dash.exceptions import PreventUpdate
 import dash_html_components as html
 import dash_core_components as dcc
+from webviz_subsurface_components import LayeredMap
+import webviz_core_components as wcc
 from webviz_config.webviz_store import webvizstore
 from webviz_config.common_cache import CACHE
 from webviz_config import WebvizPluginABC
-import webviz_core_components as wcc
-from webviz_subsurface_components import LayeredMap
 
 from webviz_subsurface._datainput.fmu_input import get_realizations, find_surfaces
 from webviz_subsurface._datainput.surface import make_surface_layer, load_surface
@@ -542,7 +542,7 @@ def add_webvizstore(self):
                     filename = f"{name}--{attr}"
                     if date is not None:
                         filename += f"--{date}"
-                    filename += f".gri"
+                    filename += ".gri"
                     filenames.append(filename)
 
         # Copy all realization files