Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add action to update smoke tests. #1975

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

ci: Add action to update smoke tests. #1975

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
593d7b4
Add action to updates smoke tests.
nilscb Mar 19, 2024
c0070cd
Updated script
nilscb Mar 20, 2024
a28fd34
fix
nilscb Mar 20, 2024
7c10a19
Merge branch 'master' into AddGithubAction
nilscb Mar 20, 2024
82af726
trigger soketests fail
nilscb Mar 20, 2024
861ce30
Merge remote-tracking branch 'origin/AddGithubAction' into AddGithubA…
nilscb Mar 20, 2024
e49b76e
Test
nilscb Mar 21, 2024
f2bb5e2
remove: "steps.check_file_changed.outputs.status == 'true' && ..."
nilscb Mar 21, 2024
94f9b7e
Test
nilscb Mar 21, 2024
e83f617
Merge branch 'master' of github.com:equinor/webviz-subsurface-compone…
hkfb Mar 27, 2024
b034942
ci: run snapshots update on push to PR
hkfb Mar 27, 2024
6a7c450
Revert "ci: run snapshots update on push to PR"
hkfb Mar 27, 2024
ea2f531
ci: trigger snapshot update on PR changes
hkfb Mar 27, 2024
16c0bfc
Merge branch 'master' into AddGithubAction
nilscb Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions .github/workflows/typescript.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,3 +143,61 @@ jobs:
npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \
"npx http-server storybook-static --port $PORT -a $HOST" \
"npx wait-on http://$HOST:$PORT/ && npm run storybook:test -- --ci --url http://$HOST:$PORT/"

smoke_tests_update:
# Run on all events defined above, except pushes which are not to master
if: github.event_name != 'push' || github.ref == 'refs/heads/master'
runs-on: ubuntu-latest
name: "Storybook Smoke Tests Update"

container:
image: mcr.microsoft.com/playwright:v1.39.0-jammy
options: --user 1001

steps:
- name: 📖 Checkout commit locally
uses: actions/checkout@v3

- name: 📦 Install build dependencies
run: |
npm ci CYPRESS_INSTALL_BINARY=0 --ignore-scripts

- name: 🏗️ Build packages
run: |
npx nx run-many -t build

- name: 📚 Build Storybook
run: npm run build-storybook

- name: Run smoke tests
env:
PORT: 8080
HOST: 127.0.0.1

run: |
npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \
"npx http-server storybook-static --port $PORT -a $HOST" \
"npx wait-on http://$HOST:$PORT/ && npm run storybook:test -- --updateSnapshot --ci --url http://$HOST:$PORT/"
hkfb marked this conversation as resolved.
Show resolved Hide resolved


# upload the failure screenshots for reference
# - name: upload artifacts
# uses: actions/upload-artifact@v4
# if: github.event_name != 'release'
# with:
# name: smoke-screenshots
# path: typescript/packages/**/__image_snapshots__/*.png
# retention-days: 5

- name: Create Pull Request
id: cpr
uses: peter-evans/create-pull-request@5a6b15373e5788c38d83296b674ad5abea28085c
if: github.event_name == 'push' && (github.ref != 'refs/heads/master' || contains(github.event.head_commit.message, '[deploy test]'))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure what to make of this, but it looks like the event_name triggered is pull_request and not push

##[debug]Evaluating condition for step: 'Create Pull Request'
##[debug]Evaluating: (success() && (github.event_name == 'push') && ((github.ref != 'refs/heads/master') || contains(github.event.head_commit.message, '[deploy test]')))
##[debug]Evaluating And:
##[debug]..Evaluating success:
##[debug]..=> true
##[debug]..Evaluating Equal:
##[debug]....Evaluating Index:
##[debug]......Evaluating github:
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'event_name'
##[debug]....=> 'pull_request'
##[debug]....Evaluating String:
##[debug]....=> 'push'
##[debug]..=> false
##[debug]=> false
##[debug]Expanded: (true && ('pull_request' == 'push') && ((github['ref'] != 'refs/heads/master') || contains(github['event']['head_commit']['message'], '[deploy test]')))

with:
commit-message: updated smoke snapshots
title: Smoke tests - New Snapshots generated for the commit "${{ github.event.head_commit.message }}" by ${{ github.event.commits[0].author.email }}
body: This is an auto-generated PR to update smoke snapshots.
base: smoke-snaps
reviewers: ${{ github.event.sender.login }}
delete-branch: true

2 changes: 1 addition & 1 deletion typescript/packages/subsurface-viewer/src/layers/axes2d/axes2DLayer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const defaultProps = {
id: "axes2d-layer",
visible: true,
coordinateSystem: COORDINATE_SYSTEM.CARTESIAN,
marginH: 80, // Horizontal margin (in pixles)
marginH: 81, // Horizontal margin (in pixles)
marginV: 30, // Vertical margin (in pixles)
isLeftRuler: true,
isRightRuler: false,
Expand Down
Loading