Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi color legend #1396

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Multi color legend #1396

wants to merge 11 commits into from

Conversation

VincentNevermore
Copy link
Contributor

image

@VincentNevermore VincentNevermore requested a review from hkfb January 18, 2023 12:32
@VincentNevermore VincentNevermore linked an issue Jan 18, 2023 that may be closed by this pull request
Create a story with multiple color legends in a single view #1349
Open
2 tasks
@hkfb hkfb added AspenTech Task owned by AspenTech map-component Issues related to the map component. enhancement New feature or request labels Jan 18, 2023
@VincentNevermore VincentNevermore requested a review from hkfb January 19, 2023 13:40
hkfb
hkfb requested changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@hkfb hkfb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log curves are obscured by them map. This example would be more useful with depthTest disabled for the log curves. Not sure if this works yet, have you tried?

Also, the view does not cover the available area, any idea why?

image

Also, please resolve the merge conflict, so that we don't have to review outdated code.

shengwei zhang added 2 commits January 20, 2023 10:20
@VincentNevermore VincentNevermore requested a review from hkfb January 20, 2023 11:01
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023 •
edited
Loading

Codecov Report

Merging #1396 (9ed39d6) into master (c68c8e2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1396   +/-   ##
=======================================
  Coverage   34.44%   34.44%           
=======================================
  Files         147      147           
  Lines        8546     8546           
  Branches     2274     2274           
=======================================
  Hits         2944     2944           
  Misses       5568     5568           
  Partials       34       34

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkfb hkfb Awaiting requested review from hkfb

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
AspenTech Task owned by AspenTech enhancement New feature or request map-component Issues related to the map component.
Projects
Webviz
Status: In Review 👀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a story with multiple color legends in a single view
3 participants
@VincentNevermore @codecov-commenter @hkfb