Skip to content

feat: Hooks for multi-picking and cursor-tracking, changes to python directory to provide functionality in Dash #5916

feat: Hooks for multi-picking and cursor-tracking, changes to python directory to provide functionality in Dash

feat: Hooks for multi-picking and cursor-tracking, changes to python directory to provide functionality in Dash #5916

Triggered via pull request December 20, 2024 11:33
Status Failure
Total duration 15m 21s
Artifacts

typescript.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 7 warnings
typescript: typescript/packages/subsurface-viewer/src/DashSubsurfaceViewer.tsx#L10
Replace `React.isValidElement(annotationContainer)·&&·(annotationContainer.type·===·ViewAnnotation·||·(annotationContainer.props·instanceof·Object·&&·Object.keys(annotationContainer.props).includes("_dashprivate_layout")))` with `⏎············React.isValidElement(annotationContainer)·&&⏎············(annotationContainer.type·===·ViewAnnotation·||⏎················(annotationContainer.props·instanceof·Object·&&⏎····················Object.keys(annotationContainer.props).includes(⏎························"_dashprivate_layout"⏎····················)))⏎········`
typescript: typescript/packages/subsurface-viewer/src/hooks/useMultiViewPicking/MultiViewPickingInfoAssembler.ts#L24
Replace `obj·&&·"propertyValue"·in·obj·&&·typeof·obj.propertyValue·===·"number"` with `(⏎········obj·&&·"propertyValue"·in·obj·&&·typeof·obj.propertyValue·===·"number"⏎····)`
typescript: typescript/packages/subsurface-viewer/src/hooks/useMultiViewPicking/MultiViewPickingInfoAssembler.ts#L43
Replace `·multiPicking:·false,·pickDepth:·1` with `⏎············multiPicking:·false,⏎············pickDepth:·1,⏎·······`
typescript: typescript/packages/subsurface-viewer/src/hooks/useMultiViewPicking/MultiViewPickingInfoAssembler.ts#L53
Replace `callback:·MultiViewPickingInfoAssemblerSubscriberCallback` with `⏎········callback:·MultiViewPickingInfoAssemblerSubscriberCallback⏎····`
typescript: typescript/packages/subsurface-viewer/src/hooks/useMultiViewPicking/MultiViewPickingInfoAssembler.ts#L87
Replace `hoverEvent.infos[0].x,·hoverEvent.infos[0].y` with `⏎············hoverEvent.infos[0].x,⏎············hoverEvent.infos[0].y,⏎········`
typescript: typescript/packages/subsurface-viewer/src/hooks/useMultiViewPicking/MultiViewPickingInfoAssembler.ts#L89
Replace `eventScreenCoordinate,·activeViewportId,·viewports` with `⏎············eventScreenCoordinate,⏎············activeViewportId,⏎············viewports⏎········`
Storybook Smoke Tests
Process completed with exit code 1.
typescript
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
typescript: typescript/packages/subsurface-viewer/src/hooks/useMultiViewPicking/MultiViewPickingInfoAssembler.ts#L2
All imports in the declaration are only used as types. Use `import type`
typescript: typescript/packages/subsurface-viewer/src/hooks/useMultiViewPicking/MultiViewPickingInfoAssembler.ts#L3
All imports in the declaration are only used as types. Use `import type`
typescript: typescript/packages/subsurface-viewer/src/layers/crosshair/crosshairLayer.ts#L1
Imports "DefaultProps" are only used as type
typescript: typescript/packages/subsurface-viewer/src/storybook/examples/MultiViewExamples.stories.tsx#L36
All imports in the declaration are only used as types. Use `import type`
Storybook Smoke Tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636