Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to react 18 and move to mui #296

Closed
wants to merge 6 commits into from
Closed

Conversation

w1nklr
Copy link
Contributor

@w1nklr w1nklr commented Aug 10, 2023

Bumps react from 16.14.0 to 18.2.0.
Bumps react-dom from 16.14.0 to 18.2.0.
Remove react-test-renderer.

Move from @material-ui to @mui 5.13.7.

Set both react and @mui packages as peer dependencies.

Bump storybook/* from 6.4.18 to 6.5.16.

w1nklr added 6 commits August 9, 2023 14:07
Bumps react from 16.14.0 to 17.0.2.
Bumps react-dom from 16.14.0 to 17.0.2.
Remove react-test-renderer.
Bumps all @storybook/* from 6.4.18 to 6.5.16.
Bumps react from 17.0.2 to 18.2.0.
Bumps react-dom from 17.0.2 to 18.2.0.
@HansKallekleiv
Copy link
Collaborator

Support for React 18 is an experimental feature in Dash and has to be explicitly activated. Default it uses React 16.

Use React version 18.2 · Issue #2254 · plotly/dash (github.com)

I'm skeptical to adding this experimental feature to our production code.

Can this PR wait? Alternatively can we make sure the code is backwards compatible with 16? E.g. not use createRoot?

@w1nklr
Copy link
Contributor Author

w1nklr commented Aug 17, 2023

Support for React 18 is an experimental feature in Dash and has to be explicitly activated. Default it uses React 16.

Use React version 18.2 · Issue #2254 · plotly/dash (github.com)

I'm skeptical to adding this experimental feature to our production code.

Can this PR wait? Alternatively can we make sure the code is backwards compatible with 16? E.g. not use createRoot?

OK, we can postpone this PR.
The move to mui 5 does break compatibility with react 16, not only the move to createRoot. :/

@w1nklr w1nklr closed this Aug 17, 2023
@w1nklr w1nklr reopened this Aug 17, 2023
@w1nklr w1nklr marked this pull request as draft August 17, 2023 07:55
@HansKallekleiv
Copy link
Collaborator

Replaced by #302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants