Oauth2 single scope to multiple scopes #598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thezultimate
requested review from
anders-kiaer,
HansKallekleiv and
asnyv
as code owners
thezultimate
force-pushed
the
oauth2-multi-scopes
branch
from
ae0f414 to
abcaaf5
Compare
anders-kiaer
requested changes
Aug 12, 2022
Comment on lines
+22
to
+23
| scope_raw = os.environ["WEBVIZ_SCOPE"] | ||
| self._scope = [scope.strip() for scope in scope_raw.split(",")] |
There was a problem hiding this comment.
Suggested change
| scope_raw = os.environ["WEBVIZ_SCOPE"] | |
| self._scope = [scope.strip() for scope in scope_raw.split(",")] | |
| self._scope = [scope.strip() for scope in os.environ["WEBVIZ_SCOPE"].split(",")] |
Maybe cleaner (saves a local variable + naming is always difficult 🙂)?
Other than that - LGTM! 👏 Thanks.
Add a changelog entry?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEBVIZ_SCOPEenvironment variable currently only supports one scope entry/value. This PR extends this to enable multiple scopes separated by comma (,).Contributor checklist
CHANGELOG.md, and added it if should be communicated there.