Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugin modules to register new webviz store return types #387

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HansKallekleiv
Copy link
Collaborator

Insert a description of your pull request (PR) here, and check off the boxes below when they are done.


Contributor checklist

  • 🎉 This PR closes #ISSUE_NUMBER.
  • 📜 I have broken down my PR into the following tasks:
    • Task 1
    • Task 2
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling plugins to register custom storage formats I guess is worth an extra feature 👍 (There are quite some domain specific objects/classes out there with their own storage/load functions).

The only "downside" I can see is that we then expose how we access WebvizStorage files to plugin authors, so maybe we should settle first on how we think files will be accessed locally and in ☁️ (@sigurdp)? Even better perhaps would be if there is an API suggestion introduced in this PR which doesn't limit ourselves to files available through OS file system (but e.g. support blob streaming using web API behind the scenes), but that abstraction is perhaps difficult.. 🤔 Especially since there are third-party libraries which already assumes file on disk (they take in file paths).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: On Hold
Development

Successfully merging this pull request may close these issues.

2 participants